Eric Wagoner
92aaa91a49
Round 3's two HIGHs: _fill_version resolved versions with the LAST same-title entry's cues (photo-aware lookup existed since round 1 but this caller never used it), and the round-2 diff rework let an earlier row's disagreement consume the exact-version copy a later row matched. Diff claims now settle strongest-first across all rows (exact matches, then versionless upgrades, then disagreement/second-copy), unvetoed bare duplicates stay owned per spec, and updates are withheld with a manual-fix note whenever any copy of the game already carries a version (the row edit targets by name and could hit the wrong copy). Also: entry-to-row pairing matches by photo overlap before position (titles.json order churn from reshoot filenames could swap editions); BGGQueueTimeout defers a title like a missing token; DismissStore writes atomically, mutates memory only after the write, and quarantines a torn file instead of bricking the server; version-picker page-limit exhaustion stays retryable; verify's copy-count shortfall reports once per game (the old guard was dead code); the upload log header is created atomically; transient version-lookup failures record a retryable version_error, not terminal version_unknown; extract isolates per-photo failures and salvages JSON followed by prose; a state revision counter stops stale poll responses reverting decisions; plus the shared-predicate/fsio/docstring consolidation and CLI wiring, live-diff, verify-wiring, and search-guard tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
41 lines
1.4 KiB
Python
41 lines
1.4 KiB
Python
"""Shared plumbing for the two stub-fixture generators.
|
|
|
|
Both write into the same cache dirs, so they must agree on XML escaping
|
|
(a title containing & or " must not produce malformed XML) and on the
|
|
provenance-marker text the upload guard depends on.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from bggpipe.config import STUB_CACHE_MARKER_NAME, STUB_DATA_MARKER_NAME
|
|
|
|
FIXTURE_CACHE = Path("tests/fixtures/bgg_cache")
|
|
|
|
CACHE_MARKER_TEXT = (
|
|
"This cache contains hand-written stub XML, not real BGG "
|
|
"responses. Data resolved from it must not be uploaded.\n"
|
|
)
|
|
DATA_MARKER_TEXT = (
|
|
"The CSVs in this directory were resolved from hand-written stub "
|
|
"fixtures, not real BGG data — version_ids are SYNTHETIC. The "
|
|
"upload stage refuses to run while this file exists. Delete it "
|
|
"only after re-resolving against real recorded fixtures "
|
|
"(BGG_API_TOKEN + scripts/record_fixtures.py + resolve --force).\n"
|
|
)
|
|
|
|
|
|
def esc(text: str) -> str:
|
|
"""Minimal XML attribute/text escaping for hand-built fixture strings."""
|
|
return str(text).replace("&", "&").replace("<", "<").replace('"', """)
|
|
|
|
|
|
def write_cache_marker(target: Path) -> None:
|
|
(target / STUB_CACHE_MARKER_NAME).write_text(CACHE_MARKER_TEXT)
|
|
|
|
|
|
def write_data_marker(data_dir: Path = Path("data")) -> None:
|
|
data_dir.mkdir(parents=True, exist_ok=True)
|
|
(data_dir / STUB_DATA_MARKER_NAME).write_text(DATA_MARKER_TEXT)
|