2 Commits

Include renames

Author	SHA1	Message	Date
Eric WagonerandClaude Fable 5	6ab4a836b4	Audit round 9 lands: the location layer keeps its promises ... Five blind reviewers over the day-old shelves layer, ~28 verified findings — plus Eric's screenshot catching the biggest one live: the generic .card is flex (built for review's photo-beside-ballot layout), so unit headers shared a row with their grids and unshelved rows flowed horizontally off the page. Shelf cards are now .card.stack. The model fixes. Containment chains resolve recursively with a cycle guard — minis inside an insert inside a big box live where the big box does, instead of vanishing from every list; the stored-in endpoint walks the whole chain when refusing cycles, and clears the newly contained game's own shelf spot (one box must never consume capacity in two openings). Contained games are listed residents but occupy no shelf space: only physical boxes are stacked and fit-checked — the web report now agrees with the dims report about the same opening. A location pointing at a vanished opening (hand-edited or reverted store) SURFACES as unshelved with a "shelf gone" chip in the app and counts as homeless in the CLI, instead of hiding the game from every list while the page declares everything has a home. Honest edges. Opening dimensions are all-or-none everywhere (a half-sized opening silently became limitless; the CLI report crashed formatting it); a second grid on a unit continues the row letters so labels stay unique and label-addressed CSV imports keep working, and row letters survive past Z; CSV re-imports preserve hand-entered notes; the ambiguity reject names the fix that actually works; corrupt furniture/locations stores speak a 500 instead of a raw traceback; the dims help text stops saying Kallax; DIM_AXES gets one home in models.py instead of three drifting copies; the new stores join CLAUDE.md's commit registry. The page behaves. Custom-dims fields hide unless the custom preset is chosen (typed values were silently discarded); the sheet is a real dialog (role, aria-modal, Escape, focus return, one layer at a time); backdrop close requires press AND release on the backdrop (a text- selection drag out of the search box no longer dismisses); refresh goes through changeGate and stops wiping the search mid-interaction; the prompt() chain is an inline per-unit form with client-side all-or-none validation; unit-create only toasts success after the openings actually land, recovers from its own half-failures, and guards against double-submit (a click retried against the re-rendering DOM built a second grid — caught live in a Playwright run); warnings speak (aria-labels on ⚠ and overfull in the fill bar's label); unmeasured boxes are visible in cells and sheet rows; the library's unshelved filter matches the Shelves page's definition; reorder buttons have names; the detail locform wraps at phone width. Eight new regression tests from the seats' sketches; 380 total. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016jXZFSTZQKzAC8fqpWSz9g	2026-08-09 14:02:00 -04:00
Eric WagonerandClaude Fable 5	4f446f6f2a	The Shelves layer: where every box physically lives ... Eric's spec, all nine points. Two committed local-only stores follow the local_games.json pattern — furniture.json (units of openings with interior dims; a dimensionless opening is a virtual spot like a travel case) and locations.json (game key -> opening + note). Shelf layouts are nobody's data but the owner's; nothing touches upload. The Shelves page builds furniture without hand-editing JSON — the acceptance bar (two double-wides above three rows of four cubes, two bookcases, a travel case) is a TEST, driven entirely through the endpoints the UI calls. Presets for Kallax/Billy/custom/virtual, grid creation with A1-style labels, openings editable/deletable/ reorderable. Units render as grids: zone, count, fill bar (stacked thinnest-axis vs interior height), ⚠ on overfull or any resident that can't fit. Openings open as a modal — a bottom sheet at phone widths, search-first with thumb-sized targets for the moving-day loop. Unshelved games list alongside with one-tap suggestions (only openings they verifiably fit, with room). Containment composes: a game stored inside another box inherits its container's location, rides along in the opening's resident list (marked), and refuses direct assignment naming its container. The detail page's where-it-lives card gains the picker (openings grouped by unit, each labeled fits / doesn't fit / can't verify) plus virtual notes ("lent to Sarah, June"); the Library list shows a location line, filters by unit or unshelved, and search matches location text and zones. bggpipe dims drops its hardcoded Kallax for the user's actual furniture: per-opening capacity, overfull and misfit warnings, unshelved count. bggpipe shelve --import loads a name,opening CSV (ids or labels), rejecting — never guessing — unknown names, ambiguous copies, unknown/ambiguous openings, misfits, and contained games. Ten new tests incl. the acceptance flow, inheritance, CSV rejects, and a phone-sheet smoke; 372 total. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016jXZFSTZQKzAC8fqpWSz9g	2026-08-09 13:45:36 -04:00