Re-audit round 3: 5 blind reviewers, 15 fixes, +18 tests — converging

Round 3's two HIGHs: _fill_version resolved versions with the LAST
same-title entry's cues (photo-aware lookup existed since round 1 but
this caller never used it), and the round-2 diff rework let an earlier
row's disagreement consume the exact-version copy a later row matched.
Diff claims now settle strongest-first across all rows (exact matches,
then versionless upgrades, then disagreement/second-copy), unvetoed
bare duplicates stay owned per spec, and updates are withheld with a
manual-fix note whenever any copy of the game already carries a version
(the row edit targets by name and could hit the wrong copy).

Also: entry-to-row pairing matches by photo overlap before position
(titles.json order churn from reshoot filenames could swap editions);
BGGQueueTimeout defers a title like a missing token; DismissStore
writes atomically, mutates memory only after the write, and
quarantines a torn file instead of bricking the server; version-picker
page-limit exhaustion stays retryable; verify's copy-count shortfall
reports once per game (the old guard was dead code); the upload log
header is created atomically; transient version-lookup failures record
a retryable version_error, not terminal version_unknown; extract
isolates per-photo failures and salvages JSON followed by prose; a
state revision counter stops stale poll responses reverting decisions;
plus the shared-predicate/fsio/docstring consolidation and CLI wiring,
live-diff, verify-wiring, and search-guard tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tests/test_models.py

@@ -116,3 +116,29 @@ def test_parse_collection():
 def test_error_document_raises():
     with pytest.raises(BGGResponseError, match="Invalid username"):
         parse_collection(ERROR_XML)
+
+
+def test_search_all_items_malformed_raises():
+    import pytest
+
+    from bggpipe.models import BGGResponseError, parse_search
+
+    xml = '<items total="2"><item type="boardgame"/><item type="boardgame"/></items>'
+    with pytest.raises(BGGResponseError):
+        parse_search(xml)
+
+
+def test_search_partial_malformed_tolerated_with_warning():
+    import pytest
+
+    from bggpipe.models import parse_search
+
+    xml = (
+        '<items total="2">'
+        '<item type="boardgame" id="13"><name type="primary" value="CATAN"/></item>'
+        '<item type="boardgame"/>'
+        "</items>"
+    )
+    with pytest.warns(UserWarning, match="unparseable"):
+        results = parse_search(xml)
+    assert [r.bgg_id for r in results] == [13]