Re-audit round 3: 5 blind reviewers, 15 fixes, +18 tests — converging

Round 3's two HIGHs: _fill_version resolved versions with the LAST
same-title entry's cues (photo-aware lookup existed since round 1 but
this caller never used it), and the round-2 diff rework let an earlier
row's disagreement consume the exact-version copy a later row matched.
Diff claims now settle strongest-first across all rows (exact matches,
then versionless upgrades, then disagreement/second-copy), unvetoed
bare duplicates stay owned per spec, and updates are withheld with a
manual-fix note whenever any copy of the game already carries a version
(the row edit targets by name and could hit the wrong copy).

Also: entry-to-row pairing matches by photo overlap before position
(titles.json order churn from reshoot filenames could swap editions);
BGGQueueTimeout defers a title like a missing token; DismissStore
writes atomically, mutates memory only after the write, and
quarantines a torn file instead of bricking the server; version-picker
page-limit exhaustion stays retryable; verify's copy-count shortfall
reports once per game (the old guard was dead code); the upload log
header is created atomically; transient version-lookup failures record
a retryable version_error, not terminal version_unknown; extract
isolates per-photo failures and salvages JSON followed by prose; a
state revision counter stops stale poll responses reverting decisions;
plus the shared-predicate/fsio/docstring consolidation and CLI wiring,
live-diff, verify-wiring, and search-guard tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

scripts/fixture_common.py

@@ -11,6 +11,8 @@ from pathlib import Path
 
 from bggpipe.config import STUB_CACHE_MARKER_NAME, STUB_DATA_MARKER_NAME
 
+FIXTURE_CACHE = Path("tests/fixtures/bgg_cache")
+
 CACHE_MARKER_TEXT = (
     "This cache contains hand-written stub XML, not real BGG "
     "responses. Data resolved from it must not be uploaded.\n"

scripts/record_fixtures.py

@@ -13,10 +13,12 @@ from __future__ import annotations
 import os
 from pathlib import Path
 
+from fixture_common import FIXTURE_CACHE
+
 from bggpipe.bgg_client import BGGClient
 from bggpipe.resolve import load_titles, resolve_entry
 
-FIXTURE_CACHE = Path("tests/fixtures/bgg_cache")
+FIXTURE_CACHE = FIXTURE_CACHE
 
 
 def main() -> None:

scripts/write_photo_fixtures.py

@@ -15,18 +15,13 @@ Usage: uv run python scripts/write_photo_fixtures.py
 
 from __future__ import annotations
 
-from pathlib import Path
-
-from fixture_common import esc, write_cache_marker, write_data_marker
+from fixture_common import FIXTURE_CACHE, esc, write_cache_marker, write_data_marker
 
 from bggpipe.bgg_client import SEARCH_TYPES, cache_key
+from bggpipe.config import Config
 
-TARGETS = (Path("tests/fixtures/bgg_cache"), Path("data/bgg_cache"))
+TARGETS = (FIXTURE_CACHE, Config().cache_dir)
 
-# Committed alongside the stub-derived CSVs (the cache markers are
-# gitignored, so this is what protects a fresh clone): upload refuses to
-# run while it exists.
-DATA_MARKER = Path("data/STUB_DATA.marker")
 
 BG, EXP = "boardgame", "boardgameexpansion"
 
@@ -362,9 +357,9 @@ def main() -> None:
         # provenance marker: anything resolved from this cache is stub-derived
         # and NOT upload-ready; re-recording real fixtures removes the marker
         write_cache_marker(target)
-    write_data_marker(DATA_MARKER.parent)
+    write_data_marker()
     print(f"Wrote {len(files)} fixture file(s) to {' and '.join(map(str, TARGETS))}")
-    print(f"Wrote {DATA_MARKER} (committed; upload refuses while it exists)")
+    print("Wrote data/STUB_DATA.marker (committed; upload refuses while it exists)")
 
 
 if __name__ == "__main__":

scripts/write_stub_fixtures.py

@@ -12,14 +12,10 @@ Usage: uv run python scripts/write_stub_fixtures.py
 
 from __future__ import annotations
 
-from pathlib import Path
-
-from fixture_common import esc, write_cache_marker
+from fixture_common import FIXTURE_CACHE, esc, write_cache_marker
 
 from bggpipe.bgg_client import SEARCH_TYPES, cache_key
 
-FIXTURE_CACHE = Path("tests/fixtures/bgg_cache")
-
 
 def search_item(bgg_id: int, name: str, year: int | None, type_: str) -> str:
     year_xml = f'<yearpublished value="{year}"/>' if year else ""