Audit: 5-reviewer sweep — 19 fixes across every stage, +24 tests
Correctness: review vetoes persist via a dedupe_veto column (resolve re-runs no longer overturn humans); diff emits second copies whose confident version matches no owned copy (spec: pairs own only on both ids) and fetches the live collection with refresh; resolve pairs titles.json entries to rows by title so a reshoot photo updates provenance instead of duplicating rows; version lookups survive empty /thing results; publisher tie-break now honors the mixed base/expansion veto and refuses multi-candidate picks; empty-normalized (non-Latin) titles never count as exact. Upload: LoginError aborts a run instead of logging N bogus failures (and 3 identical consecutive failures abort as systemic); Cloudflare interstitials are detected; added-without-version gets its own logged status that verify understands; same-game updates run one per pass so the name-targeted row edit can't overwrite a fresh version; absent diff outputs fail loudly; pagination clicks are paced. Web review: a lock serializes freshen/decide (threadpool race dropped decisions); failed saves roll memory back and always alert the browser (non-JSON 500s included); session warnings reach the page instead of a StringIO; state-load failures and dead servers show banners instead of a blank page; duplicate (title, photos) rows are addressable by ordinal. Consistency: shared CONFIDENT_VERSION_STATUSES, client_for(), Config paths for every artifact, one review-port constant, named matching thresholds, strict collection-id parsing, error-doc responses never cached, unknown config keys warn, extract reports dropped vision entries, fixture generators share escaping + marker text. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -5,6 +5,7 @@ from __future__ import annotations
|
||||
|
||||
import base64
|
||||
import io
|
||||
import json
|
||||
|
||||
import pytest
|
||||
import typer
|
||||
@@ -83,21 +84,21 @@ def test_parse_object_with_titles_and_unidentified():
|
||||
"unidentified": [{"location": "top shelf, left of Catan",
|
||||
"partial_text": "WAR", "art_notes": "red spine"}]}
|
||||
```"""
|
||||
titles, unidentified = parse_vision_response(text)
|
||||
titles, unidentified, _ = parse_vision_response(text)
|
||||
assert titles[0]["title_raw"] == "Catan"
|
||||
assert unidentified[0]["location"] == "top shelf, left of Catan"
|
||||
|
||||
|
||||
def test_parse_legacy_bare_array_still_works():
|
||||
text = '```json\n[{"title_raw": "Catan", "confidence": "high"}]\n```'
|
||||
titles, unidentified = parse_vision_response(text)
|
||||
titles, unidentified, _ = parse_vision_response(text)
|
||||
assert titles[0]["title_raw"] == "Catan"
|
||||
assert unidentified == []
|
||||
|
||||
|
||||
def test_parse_tolerates_prose_around_json():
|
||||
text = 'Here are the games:\n[{"title_raw": "Wingspan"}]\nLet me know!'
|
||||
titles, _ = parse_vision_response(text)
|
||||
titles, _, _ = parse_vision_response(text)
|
||||
assert titles[0]["title_raw"] == "Wingspan"
|
||||
|
||||
|
||||
@@ -106,7 +107,7 @@ def test_parse_drops_malformed_entries():
|
||||
'{"titles": [{"title_raw": "Catan"}, {"no_title": true}, "just a string"],'
|
||||
' "unidentified": [{}, "not a dict", {"location": "somewhere"}]}'
|
||||
)
|
||||
titles, unidentified = parse_vision_response(text)
|
||||
titles, unidentified, _ = parse_vision_response(text)
|
||||
assert len(titles) == 1
|
||||
assert len(unidentified) == 1 # empty {} and the bare string are dropped
|
||||
|
||||
@@ -227,7 +228,6 @@ def test_run_extract_empty_photos_dir_exits(tmp_path):
|
||||
|
||||
# -- unidentified sightings ---------------------------------------------
|
||||
|
||||
import json # noqa: E402
|
||||
|
||||
OBJECT_PAYLOAD = json.dumps(
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user