Loading…
-
+
@@ -50,8 +50,8 @@
-
-
+
+
@@ -75,32 +75,49 @@ function fillBar(o) {
if (!o.width_in) return ``;
const pct = Math.min(100, Math.round((o.fill || 0) * 100));
return ``;
}
function openingCell(o) {
- const warn = o.overfull || o.misfits.length
- ? `⚠`
+ const why = [
+ o.overfull ? "stacked past the interior height" : "",
+ o.misfits.length ? "doesn't fit: " + o.misfits.join(", ") : "",
+ ].filter(Boolean).join("; ");
+ const warn = why
+ ? `⚠`
: "";
+ const count = o.games
+ ? `${o.games}${o.unmeasured ? ` · ${o.unmeasured} unmeasured` : ""}`
+ : "—";
return ``;
}
function unitBlock(u) {
const cols = Math.max(1, Math.round(Math.sqrt(u.openings.length)));
- return `
+ return `
+
`;
}
@@ -114,6 +131,8 @@ function unshelvedRow(g) {
}).join("");
return ``;
@@ -134,7 +153,7 @@ function render() {
}
body.innerHTML = SHELVES.units.map(unitBlock).join("") +
(SHELVES.unshelved.length
- ? `
${esc(u.name)}
- +${u.openings.map(openingCell).join("")}
Unshelved
` + + ? `Unshelved
` + SHELVES.unshelved.map(unshelvedRow).join("") + `Everything has a home. 🎲
`); wire(); @@ -151,6 +170,8 @@ function sheetRender() {
${g.thumbnail ? `})
` : ""}
${esc(g.name)}
+ ${g.measured ? "" : `unmeasured`}
${g.inherited
? ``
: ``}
@@ -162,22 +183,42 @@ function sheetRender() {
f.elements.width_in.value = o.width_in ?? "";
f.elements.height_in.value = o.height_in ?? "";
f.elements.depth_in.value = o.depth_in ?? "";
- document.getElementById("sheetsearch").value = "";
- document.getElementById("sheetmatches").innerHTML = "";
}
+let SHEET_OPENER = null; // the button to hand focus back to on close
+
function openSheet(id) {
OPEN = id;
+ SHEET_OPENER = document.activeElement;
+ document.getElementById("unitform").hidden = true; // one layer at a time
+ document.querySelectorAll(".addopeningform").forEach(f => f.hidden = true);
+ document.getElementById("sheetsearch").value = "";
+ document.getElementById("sheetmatches").innerHTML = "";
document.getElementById("opensheet").hidden = false;
sheetRender();
document.getElementById("sheetsearch").focus();
}
+function closeSheet() {
+ document.getElementById("opensheet").hidden = true;
+ OPEN = null;
+ if (SHEET_OPENER && document.contains(SHEET_OPENER)) SHEET_OPENER.focus();
+ SHEET_OPENER = null;
+}
+
+const GATE = changeGate();
async function refresh() {
- SHELVES = await fetchJSON("/api/shelves");
- if (!LIBRARY.length) LIBRARY = await fetchJSON("/api/library");
- render();
- if (OPEN) sheetRender();
+ // the library refreshes too: a game enriched mid-session must be
+ // findable in the sheet's search without a page reload
+ const [shelves, library] = await Promise.all([
+ fetchJSON("/api/shelves"), fetchJSON("/api/library"),
+ ]);
+ GATE({shelves, library}, () => {
+ SHELVES = shelves;
+ LIBRARY = library;
+ render();
+ if (OPEN) sheetRender();
+ });
}
async function post(url, body) {
@@ -202,29 +243,45 @@ function wire() {
});
document.querySelectorAll(".addopening").forEach(b =>
b.onclick = () => {
- const label = prompt("Label for the new opening (e.g. wide top left):");
- if (!label) return;
- const w = prompt("Interior width in inches (blank = no size limits):");
- const h = w ? prompt("Interior height in inches:") : "";
- const d = w ? prompt("Interior depth in inches:") : "";
- post("/api/furniture/add-openings", {
- unit: b.dataset.unit, label,
- width_in: parseFloat(w) || null, height_in: parseFloat(h) || null,
- depth_in: parseFloat(d) || null,
+ const form = document.querySelector(
+ `.addopeningform[data-unit="${CSS.escape(b.dataset.unit)}"]`);
+ form.hidden = !form.hidden;
+ b.setAttribute("aria-expanded", String(!form.hidden));
+ if (!form.hidden) form.elements.label.focus();
+ });
+ document.querySelectorAll(".addopeningform").forEach(form =>
+ form.onsubmit = async e => {
+ e.preventDefault();
+ const f = form.elements;
+ const dims = [f.width_in.value, f.height_in.value, f.depth_in.value];
+ const given = dims.filter(v => v.trim()).length;
+ if (given && given < 3) {
+ alert("Give all three interior dimensions, or none for a no-limit spot.");
+ return;
+ }
+ await post("/api/furniture/add-openings", {
+ unit: form.dataset.unit, label: f.label.value, zone: f.zone.value,
+ width_in: parseFloat(f.width_in.value) || null,
+ height_in: parseFloat(f.height_in.value) || null,
+ depth_in: parseFloat(f.depth_in.value) || null,
});
});
}
// -- the sheet ----------------------------------------------------------
-document.getElementById("sheetclose").addEventListener("click", () => {
- document.getElementById("opensheet").hidden = true;
- OPEN = null;
+document.getElementById("sheetclose").addEventListener("click", closeSheet);
+document.addEventListener("keydown", e => {
+ if (e.key === "Escape" && OPEN) closeSheet();
+});
+// close only when BOTH press and release land on the backdrop — a text-
+// selection drag out of the search box must not dismiss the sheet
+let downOnBackdrop = false;
+document.getElementById("opensheet").addEventListener("pointerdown", e => {
+ downOnBackdrop = e.target.id === "opensheet";
});
document.getElementById("opensheet").addEventListener("click", e => {
- if (e.target.id === "opensheet") {
- document.getElementById("opensheet").hidden = true;
- OPEN = null;
- }
+ if (downOnBackdrop && e.target.id === "opensheet") closeSheet();
+ downOnBackdrop = false;
});
document.getElementById("sheetgames").addEventListener("click", e => {
const b = e.target.closest(".unassign");
@@ -249,12 +306,17 @@ document.getElementById("sheetsearch").addEventListener("input", () => {
document.getElementById("openingform").addEventListener("submit", e => {
e.preventDefault();
const f = e.target.elements;
+ const given = [f.width_in.value, f.height_in.value, f.depth_in.value]
+ .filter(v => v.trim()).length;
+ if (given && given < 3) {
+ alert("Give all three interior dimensions, or none to remove size limits.");
+ return;
+ }
post("/api/furniture/edit-opening", {
id: OPEN, label: f.label.value, zone: f.zone.value,
width_in: parseFloat(f.width_in.value) || null,
height_in: parseFloat(f.height_in.value) || null,
depth_in: parseFloat(f.depth_in.value) || null,
- clear_dims: !f.width_in.value,
});
});
document.getElementById("openingup").addEventListener("click", () =>
@@ -264,8 +326,7 @@ document.getElementById("openingdown").addEventListener("click", () =>
document.getElementById("openingdelete").addEventListener("click", () => {
if (confirm("Delete this opening? Its games become unshelved.")) {
const gone = OPEN;
- OPEN = null;
- document.getElementById("opensheet").hidden = true;
+ closeSheet();
post("/api/furniture/delete-opening", {id: gone});
}
});
@@ -282,22 +343,31 @@ const addUnitBtn = document.getElementById("addunit");
addUnitBtn.addEventListener("click", () => {
unitForm.hidden = !unitForm.hidden;
addUnitBtn.setAttribute("aria-expanded", String(!unitForm.hidden));
+ syncDims();
if (!unitForm.hidden) unitForm.elements.name.focus();
});
document.getElementById("unitcancel").addEventListener("click", () => {
unitForm.hidden = true;
unitForm.reset();
+ syncDims();
});
-unitForm.elements.preset.addEventListener("change", () => {
+function syncDims() {
const v = unitForm.elements.preset.value;
document.getElementById("customdims").hidden = v !== "custom";
if (v === "virtual") {
unitForm.elements.rows.value = 1;
unitForm.elements.cols.value = 1;
}
-});
+}
+unitForm.elements.preset.addEventListener("change", syncDims);
unitForm.addEventListener("submit", async e => {
e.preventDefault();
+ // a double-click (or a click retried against the re-rendering DOM)
+ // must not create a second grid: one submit in flight at a time
+ const createBtn = unitForm.querySelector('button[type="submit"]');
+ if (createBtn.disabled) return;
+ createBtn.disabled = true;
+ try {
const f = unitForm.elements;
const preset = PRESETS[f.preset.value];
const dims = f.preset.value === "custom"
@@ -305,17 +375,27 @@ unitForm.addEventListener("submit", async e => {
height_in: parseFloat(f.height_in.value) || null,
depth_in: parseFloat(f.depth_in.value) || null}
: preset || {};
- const made = await post("/api/furniture/add-unit", {name: f.name.value});
- if (!made) return;
- await post("/api/furniture/add-openings", {
+ // create-then-fill is two calls: an existing empty unit (a previous
+ // half-failure) is fine to fill, so a 409 on step one does not stop us
+ const existing = SHELVES.units.find(u => u.name === f.name.value.trim());
+ if (!existing || existing.openings.length) {
+ const made = await post("/api/furniture/add-unit", {name: f.name.value});
+ if (!made && !existing) return;
+ }
+ const filled = await post("/api/furniture/add-openings", {
unit: f.name.value.trim(), zone: f.zone.value,
rows: parseInt(f.rows.value) || 1, cols: parseInt(f.cols.value) || 1,
...dims,
});
+ if (!filled) return; // the unit exists but empty: resubmit retries
showToast(`${esc(f.name.value)} is up — click any opening to fill it,
or add more openings for its other sections`);
unitForm.reset();
+ syncDims();
unitForm.hidden = true;
+ } finally {
+ createBtn.disabled = false;
+ }
});
refresh().catch(err => errorBanner(err.message || err));
diff --git a/src/bggpipe/webreview.py b/src/bggpipe/webreview.py
index e133dba..c926a69 100644
--- a/src/bggpipe/webreview.py
+++ b/src/bggpipe/webreview.py
@@ -244,10 +244,10 @@ class OpeningEditBody(BaseModel):
id: str
label: str | None = None
zone: str | None = None
+ # all three or none: a partial size cannot exist (see the endpoint)
width_in: float | None = None
height_in: float | None = None
depth_in: float | None = None
- clear_dims: bool = False # explicit: make it a virtual location
class OpeningMoveBody(BaseModel):
@@ -1050,22 +1050,34 @@ def create_app(
# -- the physical-location layer -----------------------------------
+ def _shelf_stores():
+ """Furniture + locations for endpoints: corrupt stores become a
+ spoken 500, not a raw traceback."""
+ try:
+ return load_furniture(cfg), load_locations(cfg)
+ except ValueError as err:
+ raise HTTPException(500, str(err)) from err
+
def _shelf_state() -> dict:
"""Units with per-opening capacity + resident games, the unshelved
list with fit-checked suggestions, and virtual locations."""
games = read_games()
- units = load_furniture(cfg)
- locations = load_locations(cfg)
+ units, locations = _shelf_stores()
openings = opening_index(units)
residents: dict[str, list[tuple[str, dict]]] = {}
located_keys: set[str] = set()
+ lost_home: set[str] = set()
for key, entry in games.items():
oid, _, via = effective_location(key, entry, games, locations)
if oid and oid in openings:
residents.setdefault(oid, []).append((key, entry))
located_keys.add(key)
+ elif oid and via is None:
+ # assigned to an opening that no longer exists (a store
+ # edited or reverted by hand): SURFACE it, never hide it
+ lost_home.add(key)
elif via is not None:
- located_keys.add(key) # inherits; container is unshelved
+ located_keys.add(key) # rides with its container
out_units = []
for unit in units:
out_openings = []
@@ -1082,6 +1094,7 @@ def create_app(
"name": e.get("name"),
"thumbnail": e.get("thumbnail") or "",
"inherited": bool(e.get("stored_in")),
+ "measured": game_dims(e) is not None,
}
for k, e in sorted(
here,
@@ -1097,8 +1110,6 @@ def create_app(
):
if key in located_keys or entry.get("stored_in"):
continue
- if (locations.get(key) or {}).get("opening_id"):
- continue # assigned to an opening that no longer exists? keep out
note = (locations.get(key) or {}).get("note", "")
suggestions = [
oid
@@ -1114,6 +1125,7 @@ def create_app(
"thumbnail": entry.get("thumbnail") or "",
"note": note,
"measured": game_dims(entry) is not None,
+ "lost_home": key in lost_home,
"suggestions": suggestions,
}
)
@@ -1126,9 +1138,13 @@ def create_app(
return _shelf_state()
def _mutate_furniture(fn) -> dict:
+ # no _refuse_if_rewriting here: furniture/locations aren't pipeline
+ # artifacts — an extract/resolve rewrite can't clobber them (the
+ # stored-in endpoint edits MATCH rows, hence its guard)
with lock:
revision["n"] += 1
- units = load_furniture(cfg)
+ freshen()
+ units, _ = _shelf_stores()
fn(units)
save_furniture(cfg, units)
return _shelf_state()
@@ -1174,10 +1190,33 @@ def create_app(
"height_in": body.height_in or None,
"depth_in": body.depth_in or None,
}
+ given = [v for v in dims.values() if v]
+ if given and len(given) < 3:
+ # a half-sized opening would silently become limitless:
+ # fit checks need all three axes, or none (virtual)
+ raise HTTPException(400, "give all three interior dimensions, or none")
if body.rows and body.cols:
- for r in range(body.rows):
+ # a second grid on the same unit continues the row letters
+ # (A1 already exists -> next section starts at C, say):
+ # labels stay unique, so label-addressed CSV imports work
+ used = [
+ ord(o["label"][0]) - 65
+ for o in unit["openings"]
+ if len(o["label"]) >= 2
+ and o["label"][0].isalpha()
+ and o["label"][1:].isdigit()
+ ]
+ start = max(used) + 1 if used else 0
+ for r in range(start, start + body.rows):
+ letters = ""
+ n = r
+ while True:
+ letters = chr(65 + n % 26) + letters
+ n = n // 26 - 1
+ if n < 0:
+ break
for c in range(body.cols):
- label = f"{chr(65 + r)}{c + 1}"
+ label = f"{letters}{c + 1}"
unit["openings"].append(
{
"id": new_opening_id(units, unit["name"], label),
@@ -1212,13 +1251,21 @@ def create_app(
real["label"] = body.label.strip() or real["label"]
if body.zone is not None:
real["zone"] = body.zone.strip()
- if body.clear_dims:
+ # dims are all-or-none: three values sets, three blanks makes
+ # it virtual, anything else is a 400 — a partial edit must
+ # never silently strip an opening of its size limits
+ dims = [body.width_in, body.height_in, body.depth_in]
+ given = [v for v in dims if v]
+ if len(given) == 3:
+ real.update(
+ width_in=body.width_in,
+ height_in=body.height_in,
+ depth_in=body.depth_in,
+ )
+ elif not given:
real.update(width_in=None, height_in=None, depth_in=None)
else:
- for field in ("width_in", "height_in", "depth_in"):
- value = getattr(body, field)
- if value is not None:
- real[field] = value
+ raise HTTPException(400, "give all three interior dimensions, or none")
return _mutate_furniture(apply)
@@ -1321,6 +1368,29 @@ def create_app(
)
if holder is None:
raise HTTPException(400, "the container must be a cataloged game")
+ # walk the WHOLE chain: A in B in C in A must refuse too
+ seen = {body.key}
+ probe = holder
+ while probe is not None:
+ probe_key = next((k for k, e in games.items() if e is probe), None)
+ if probe_key in seen:
+ raise HTTPException(
+ 400, "that would make the boxes contain each other"
+ )
+ seen.add(probe_key)
+ inner = probe.get("stored_in")
+ probe = (
+ next(
+ (
+ e
+ for e in games.values()
+ if str(e.get("bgg_id")) == str(inner)
+ ),
+ None,
+ )
+ if inner
+ else None
+ )
if str(holder.get("stored_in") or "") == str(entry.get("bgg_id")):
raise HTTPException(400, "that box already lives inside THIS one")
rows = read_matches(cfg.matches_path)
@@ -1351,6 +1421,13 @@ def create_app(
cfg.games_path,
json.dumps(games, indent=2, ensure_ascii=False) + "\n",
)
+ if container:
+ # it rides with its container now: a lingering shelf spot
+ # of its own would count its thickness in TWO openings
+ locations = load_locations(cfg)
+ if body.key in locations:
+ locations.pop(body.key)
+ save_locations(cfg, locations)
return {"stored_in": container or None}
@app.get("/api/library/{key:path}")
diff --git a/tests/test_shelves.py b/tests/test_shelves.py
index 97869fe..3e3c0dd 100644
--- a/tests/test_shelves.py
+++ b/tests/test_shelves.py
@@ -360,3 +360,260 @@ def test_shelves_page_serves_with_phone_sheet(tmp_path):
assert 'href="/shelves" aria-current="page"' in html
css = web.get("/static/app.css").text
assert "max-width: 900px" in css and ".sheetcard" in css
+
+
+def test_stored_in_chain_resolves_to_the_outermost_box(tmp_path):
+ """Minis inside an insert inside a big box live wherever the big box
+ does — a two-level chain must not vanish from the shelves page."""
+ games = {
+ "1": {
+ "bgg_id": 1,
+ "name": "Trove",
+ "dims": {
+ "width_in": 12,
+ "length_in": 12,
+ "depth_in": 4,
+ "source": "version",
+ },
+ },
+ "2": {"bgg_id": 2, "name": "Insert", "stored_in": "1"},
+ "3": {"bgg_id": 3, "name": "Minis", "stored_in": "2"},
+ }
+ web, cfg = _web(tmp_path, games)
+ web.post("/api/furniture/add-unit", json={"name": "Den"})
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Den",
+ "label": "A1",
+ "width_in": 13.25,
+ "height_in": 13.25,
+ "depth_in": 15.4,
+ },
+ )
+ opening = web.get("/api/shelves").json()["units"][0]["openings"][0]["id"]
+ web.post("/api/locate", json={"key": "1", "opening_id": opening})
+ state = web.get("/api/shelves").json()
+ resident = state["units"][0]["openings"][0]["resident_games"]
+ assert {g["name"] for g in resident} == {"Trove", "Insert", "Minis"}
+ # only the physical box is stacked and counted
+ assert state["units"][0]["openings"][0]["games"] == 1
+ assert state["units"][0]["openings"][0]["stacked_in"] == 4
+ assert state["unshelved"] == []
+
+ # deep cycles refuse: Trove into Minis would close the loop
+ res = web.post("/api/stored-in", json={"key": "1", "container": "3"})
+ assert res.status_code == 400
+
+
+def test_stored_in_clears_the_games_own_shelf_spot(tmp_path):
+ """Shelve X, then declare X lives inside B: X's own location record
+ must go — one box must never consume capacity in two openings."""
+ games = {
+ "1": {
+ "bgg_id": 1,
+ "name": "Big Box",
+ "dims": {
+ "width_in": 12,
+ "length_in": 12,
+ "depth_in": 4,
+ "source": "version",
+ },
+ },
+ "2": {
+ "bgg_id": 2,
+ "name": "Little Box",
+ "dims": {"width_in": 8, "length_in": 8, "depth_in": 2, "source": "version"},
+ },
+ }
+ web, cfg = _web(tmp_path, games)
+ from bggpipe.resolve import MATCH_COLUMNS, write_matches
+
+ write_matches(
+ cfg.matches_path,
+ [
+ {
+ **dict.fromkeys(MATCH_COLUMNS, ""),
+ "title_raw": name,
+ "bgg_id": str(i),
+ "bgg_name": name,
+ "match_status": "approved",
+ }
+ for i, name in ((1, "Big Box"), (2, "Little Box"))
+ ],
+ )
+ web.post("/api/furniture/add-unit", json={"name": "Den"})
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Den",
+ "rows": 1,
+ "cols": 2,
+ "width_in": 13.25,
+ "height_in": 13.25,
+ "depth_in": 15.4,
+ },
+ )
+ openings = [o["id"] for o in web.get("/api/shelves").json()["units"][0]["openings"]]
+ web.post("/api/locate", json={"key": "1", "opening_id": openings[0]})
+ web.post("/api/locate", json={"key": "2", "opening_id": openings[1]})
+ assert (
+ web.post("/api/stored-in", json={"key": "2", "container": "1"}).status_code
+ == 200
+ )
+ locations = json.loads(cfg.locations_path.read_text())
+ assert "2" not in locations # its own spot is gone; it rides with Big Box
+ state = web.get("/api/shelves").json()
+ assert state["units"][0]["openings"][1]["games"] == 0
+
+
+def test_delete_unit_clears_only_its_own_locations(tmp_path):
+ games = {
+ "1": {
+ "bgg_id": 1,
+ "name": "A",
+ "dims": {"width_in": 8, "length_in": 8, "depth_in": 2, "source": "version"},
+ },
+ "2": {
+ "bgg_id": 2,
+ "name": "B",
+ "dims": {"width_in": 8, "length_in": 8, "depth_in": 2, "source": "version"},
+ },
+ }
+ web, cfg = _web(tmp_path, games)
+ for name in ("Den", "Loft"):
+ web.post("/api/furniture/add-unit", json={"name": name})
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": name,
+ "label": "A1",
+ "width_in": 13.25,
+ "height_in": 13.25,
+ "depth_in": 15.4,
+ },
+ )
+ state = web.get("/api/shelves").json()
+ den = state["units"][0]["openings"][0]["id"]
+ loft = state["units"][1]["openings"][0]["id"]
+ web.post("/api/locate", json={"key": "1", "opening_id": den})
+ web.post("/api/locate", json={"key": "2", "opening_id": loft})
+ web.post("/api/furniture/delete-unit", json={"name": "Den"})
+ locations = json.loads(cfg.locations_path.read_text())
+ assert "1" not in locations and locations["2"]["opening_id"] == loft
+ state = web.get("/api/shelves").json()
+ assert [g["name"] for g in state["unshelved"]] == ["A"]
+
+
+def test_locate_clearing_both_fields_deletes_the_record(tmp_path):
+ games = {"1": {"bgg_id": 1, "name": "A"}}
+ web, cfg = _web(tmp_path, games)
+ web.post("/api/locate", json={"key": "1", "note": "lent out"})
+ assert json.loads(cfg.locations_path.read_text())["1"]["note"] == "lent out"
+ web.post("/api/locate", json={"key": "1", "opening_id": "", "note": ""})
+ assert "1" not in json.loads(cfg.locations_path.read_text())
+
+
+def test_ghost_opening_assignment_surfaces_as_unshelved(tmp_path):
+ """A location pointing at a vanished opening (hand-edited or reverted
+ store) must SHOW — silently disappearing from every list is how a
+ game gets lost for real."""
+ from bggpipe.shelves import save_locations
+
+ games = {"1": {"bgg_id": 1, "name": "Ghosted"}}
+ web, cfg = _web(tmp_path, games)
+ save_locations(cfg, {"1": {"opening_id": "gone-a9", "note": ""}})
+ state = web.get("/api/shelves").json()
+ (row,) = state["unshelved"]
+ assert row["name"] == "Ghosted" and row["lost_home"] is True
+
+
+def test_partial_dims_refuse_everywhere(tmp_path):
+ web, cfg = _web(tmp_path, {})
+ web.post("/api/furniture/add-unit", json={"name": "Den"})
+ res = web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Den",
+ "label": "half",
+ "width_in": 13.0,
+ },
+ )
+ assert res.status_code == 400
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Den",
+ "label": "whole",
+ "width_in": 13.0,
+ "height_in": 13.0,
+ "depth_in": 15.0,
+ },
+ )
+ oid = web.get("/api/shelves").json()["units"][0]["openings"][0]["id"]
+ assert (
+ web.post(
+ "/api/furniture/edit-opening",
+ json={
+ "id": oid,
+ "height_in": 14.0,
+ },
+ ).status_code
+ == 400
+ ) # partial edit refused
+ # all three blanks makes it virtual, deliberately
+ web.post("/api/furniture/edit-opening", json={"id": oid})
+ opening = web.get("/api/shelves").json()["units"][0]["openings"][0]
+ assert opening["width_in"] is None
+
+
+def test_second_grid_continues_row_letters(tmp_path):
+ web, cfg = _web(tmp_path, {})
+ web.post("/api/furniture/add-unit", json={"name": "Wall"})
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Wall",
+ "rows": 2,
+ "cols": 2,
+ "width_in": 13.0,
+ "height_in": 13.0,
+ "depth_in": 15.0,
+ },
+ )
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Wall",
+ "rows": 1,
+ "cols": 2,
+ "width_in": 26.5,
+ "height_in": 13.0,
+ "depth_in": 15.0,
+ },
+ )
+ labels = [
+ o["label"] for o in web.get("/api/shelves").json()["units"][0]["openings"]
+ ]
+ assert labels == ["A1", "A2", "B1", "B2", "C1", "C2"]
+ assert len(set(labels)) == 6 # unique: label-addressed CSVs stay usable
+
+
+def test_move_opening_boundaries_no_op(tmp_path):
+ web, cfg = _web(tmp_path, {})
+ web.post("/api/furniture/add-unit", json={"name": "Den"})
+ web.post(
+ "/api/furniture/add-openings",
+ json={
+ "unit": "Den",
+ "rows": 1,
+ "cols": 2,
+ "width_in": 13.0,
+ "height_in": 13.0,
+ "depth_in": 15.0,
+ },
+ )
+ ids = [o["id"] for o in web.get("/api/shelves").json()["units"][0]["openings"]]
+ web.post("/api/furniture/move-opening", json={"id": ids[0], "direction": -1})
+ after = [o["id"] for o in web.get("/api/shelves").json()["units"][0]["openings"]]
+ assert after == ids # first can't move earlier: quiet no-op